This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Make importable with webpack 2#23
Open
christiaanwesterbeek wants to merge 1 commit intonmccready:masterfrom
Open
Make importable with webpack 2#23christiaanwesterbeek wants to merge 1 commit intonmccready:masterfrom
christiaanwesterbeek wants to merge 1 commit intonmccready:masterfrom
Conversation
Owner
|
Can you update the Travis issues? First try updating mode and some of the dependencies. I will merge this if we can get this to pass. |
Author
|
I'm sorry @nmccready , but that will take me too much time considering my agenda. If nobody is interested in fixing the Travis issues and it doesn't get merged, I'll understand and I will use a local wrapper in that case so to fix the webpack importability. |
Owner
|
Ok when I get a chance I'll merge it locally and attempt to fix Travis.
On Sat, Jul 22, 2017 at 15:01 Christiaan Westerbeek < ***@***.***> wrote:
I'm sorry @nmccready <https://github.com/nmccready> , but that will take
me to much time considering my agenda. If nobody is interested in fixing
the Travis issues and it doesn't get merged, I'll understand and I will use
a local wrapper in that case so to fix the webpack importability.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjnqdQsYWrw26-WtV7TFAjeWjGGMH9Aks5sQkcPgaJpZM4NduD->
.
--
=====================
Nicholas McCready
Personal Email: nmccready@gmail.com
Web site: http://github.com/nmccready
Twitter: nmccready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Webpack 2 and Angular 1.x with this
Is throwing this angular error when it spins up
I'm not sure why, but the change in this PR fixes that. Not sure if it introduces other problems.